TST Extend tests for scipy.sparse.*array in sklearn/tests/test_multioutput.py#27171
Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom Aug 28, 2023
Merged
Conversation
work-mohit
approved these changes
Aug 26, 2023
Contributor
work-mohit
left a comment
There was a problem hiding this comment.
LGTM !
And thanks, your code helped me in fixing some error.
OmarManzoor
approved these changes
Aug 28, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @naman1608
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
Member
|
There is actually a bug in SciPy: /usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/scipy/sparse/_base.py:251: in __iter__
yield self[r, :]
r = 0
self = <50x100 sparse array of type '<class 'numpy.float64'>'
with 5000 stored elements in Dictionary Of Keys format>
/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/scipy/sparse/_index.py:53: in __getitem__
self._raise_on_1d_array_slice()
col = slice(None, None, None)
key = (0, slice(None, None, None))
row = 0
self = <50x100 sparse array of type '<class 'numpy.float64'>'
with 5000 stored elements in Dictionary Of Keys format>We should absolutely trigger the CI with |
Member
|
@glemaitre do you have a link to the full traceback? |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27090.
What does this implement/fix? Explain your changes.
Any other comments?