Skip to content

TST Extend tests for scipy.sparse.*array in test_mlp.py#27163

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
bharatr21:sparse-mlp
Aug 28, 2023
Merged

TST Extend tests for scipy.sparse.*array in test_mlp.py#27163
ogrisel merged 1 commit intoscikit-learn:mainfrom
bharatr21:sparse-mlp

Conversation

@bharatr21
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #27090

What does this implement/fix? Explain your changes.

Extend tests for scipy.sparse.*array in sklearn/neural_network/tests/test_mlp.py

Any other comments?

None

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ddfd76e. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@work-mohit work-mohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! and CI is also green.
Good work @bharatr21

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bharatr21

@jjerphan jjerphan changed the title TST: Extend tests for scipy.sparse.*array in test_mlp.py TST Extend tests for scipy.sparse.*array in test_mlp.py Aug 27, 2023
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ogrisel ogrisel merged commit 50dde09 into scikit-learn:main Aug 28, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants