TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_perceptron.py#27160
Merged
ogrisel merged 5 commits intoscikit-learn:mainfrom Aug 28, 2023
Merged
TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_perceptron.py#27160ogrisel merged 5 commits intoscikit-learn:mainfrom
scipy.sparse.*array in sklearn/linear_model/tests/test_perceptron.py#27160ogrisel merged 5 commits intoscikit-learn:mainfrom
Conversation
scipy.sparse.*array in <filename>scipy.sparse.*array in sklearn/linear_model/tests/test_perceptron.py
OmarManzoor
reviewed
Aug 25, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR! Here are a few suggestions.
ogrisel
reviewed
Aug 25, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the PR, please see the comments below:
Contributor
Author
|
Thanks so much for the suggestions! Everything should be fixed up now, let me know if I need to do anything else. |
OmarManzoor
approved these changes
Aug 28, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks @IsaacTrost. LGTM.
ogrisel
approved these changes
Aug 28, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR and thanks for taking our feedback into account!
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…ests/test_perceptron.py` (scikit-learn#27160)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…ests/test_perceptron.py` (scikit-learn#27160)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Towards #27090. Added sparce array tests to a test file.
No changelog should be necessary for this fix.
Any other comments?
As per the issue I tackled, this is my first time contributing to this repo. I believe I did everything the issue asked for, though I am unsure.