Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_pca.py#27150

Merged
ogrisel merged 3 commits intoscikit-learn:mainfrom
work-mohit:fix/tst/decomposition/tests/test_pca.py
Aug 25, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_pca.py#27150
ogrisel merged 3 commits intoscikit-learn:mainfrom
work-mohit:fix/tst/decomposition/tests/test_pca.py

Conversation

@work-mohit
Copy link
Copy Markdown
Contributor

Towords #27090

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: acd6052. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @work-mohit

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ogrisel ogrisel merged commit 474cd98 into scikit-learn:main Aug 25, 2023
@work-mohit work-mohit deleted the fix/tst/decomposition/tests/test_pca.py branch August 25, 2023 07:38
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants