Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_linear_loss.py#27133

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
bncer:tst-linear-loss
Aug 23, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_linear_loss.py#27133
ogrisel merged 1 commit intoscikit-learn:mainfrom
bncer:tst-linear-loss

Conversation

@bncer
Copy link
Copy Markdown
Contributor

@bncer bncer commented Aug 22, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

This PR adds test cases of scipy's sparse array into sklearn/linear_model/tests/test_linear_loss.py file

Any other comments?

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c86faf7. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bncer

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit 7ad7090 into scikit-learn:main Aug 23, 2023
@bncer bncer deleted the tst-linear-loss branch August 23, 2023 17:10
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants