Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/neighbors/tests/test_nearest_centroid.py#27132

Merged
ogrisel merged 5 commits intoscikit-learn:mainfrom
naman1608:sparse_array_nearest_centroid
Aug 25, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/neighbors/tests/test_nearest_centroid.py#27132
ogrisel merged 5 commits intoscikit-learn:mainfrom
naman1608:sparse_array_nearest_centroid

Conversation

@naman1608
Copy link
Copy Markdown
Contributor

@naman1608 naman1608 commented Aug 22, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2724c93. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @naman1608. Just pointed out some minor formatting comments otherwise LGTM.

naman1608 and others added 3 commits August 23, 2023 22:30
@naman1608 naman1608 requested a review from OmarManzoor August 23, 2023 17:46
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ogrisel ogrisel merged commit 6c18131 into scikit-learn:main Aug 25, 2023
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
…s/test_nearest_centroid.py` (scikit-learn#27132)

Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
…s/test_nearest_centroid.py` (scikit-learn#27132)

Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…s/test_nearest_centroid.py` (scikit-learn#27132)

Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants