Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_incremental_pca.py#27131

Merged
ogrisel merged 2 commits intoscikit-learn:mainfrom
yuanx749:sparse-array-ipca
Aug 23, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_incremental_pca.py#27131
ogrisel merged 2 commits intoscikit-learn:mainfrom
yuanx749:sparse-array-ipca

Conversation

@yuanx749
Copy link
Copy Markdown
Contributor

Towards #27090.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: afb8f60. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanx749. LGTM.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit 2720ce7 into scikit-learn:main Aug 23, 2023
@yuanx749 yuanx749 deleted the sparse-array-ipca branch August 23, 2023 16:43
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants