DOC add feature_names_in_ in the docsring of ColumnTransformer#27130
Merged
ArturoAmorQ merged 5 commits intoscikit-learn:mainfrom Sep 12, 2023
Merged
DOC add feature_names_in_ in the docsring of ColumnTransformer#27130ArturoAmorQ merged 5 commits intoscikit-learn:mainfrom
ArturoAmorQ merged 5 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
reviewed
Aug 29, 2023
Comment on lines
+176
to
+177
| Names of features seen during :term:`fit`. Only defined if the | ||
| underlying estimators expose such an attribute when fit. |
Member
There was a problem hiding this comment.
I think you mean to say "Only defined if X has feature names during fit"? This doesn't have anything to do with the underlying estimators 😁
9cd2a18 to
5f141a3
Compare
Member
Author
|
ping @ArturoAmorQ Could you review this one. |
ArturoAmorQ
reviewed
Sep 12, 2023
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was a bit surprised thinking that
feature_names_in_was not available in theColumnTransformerbut it actually does when passing a DataFrame like any other transformer.Correcting the docstring in this PR.