TST Extend tests for scipy.sparse.*array in sklearn/svm/tests/test_bounds.py#27121
Merged
ogrisel merged 4 commits intoscikit-learn:mainfrom Aug 22, 2023
Merged
TST Extend tests for scipy.sparse.*array in sklearn/svm/tests/test_bounds.py#27121ogrisel merged 4 commits intoscikit-learn:mainfrom
scipy.sparse.*array in sklearn/svm/tests/test_bounds.py#27121ogrisel merged 4 commits intoscikit-learn:mainfrom
Conversation
OmarManzoor
approved these changes
Aug 21, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks @naman1608. LGTM!
ogrisel
requested changes
Aug 21, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
I would rather avoid the csr_container=csr_array/X_label="dense" and csr_container=csr_matrix/X_label="dense" cases.
Instead you could update this test to drop X_label and parametrize X_container with CSR_CONTAINERS + [np.array].
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #27090.