TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hierarchical.py#27101
Merged
ogrisel merged 10 commits intoscikit-learn:mainfrom Aug 28, 2023
Merged
TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hierarchical.py#27101ogrisel merged 10 commits intoscikit-learn:mainfrom
scipy.sparse.*array in sklearn/cluster/tests/test_hierarchical.py#27101ogrisel merged 10 commits intoscikit-learn:mainfrom
Conversation
OmarManzoor
reviewed
Aug 22, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @vvkrddy. Here are a few comments.
OmarManzoor
reviewed
Aug 25, 2023
OmarManzoor
reviewed
Aug 25, 2023
Added a new line at the end to avoid merge conflict.
Member
|
@vvkrddy could you please fix the linting issues by following the instructions in the comments by the linting bot? |
OmarManzoor
approved these changes
Aug 28, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @vvkrddy
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…test_hierarchical.py` (scikit-learn#27101)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…test_hierarchical.py` (scikit-learn#27101)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27090.