Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py#27099

Merged
ogrisel merged 4 commits intoscikit-learn:mainfrom
Kislovskiy:towards-27090-test_bisect_k_means.py
Aug 18, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py#27099
ogrisel merged 4 commits intoscikit-learn:mainfrom
Kislovskiy:towards-27090-test_bisect_k_means.py

Conversation

@Kislovskiy
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@Kislovskiy Kislovskiy changed the title TST Extend tests for scipy.sparse.*array in scikit-learn/sklearn/cluster/tests/test_bisect_k_means.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py Aug 18, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cb75060. Link to the linter CI: here

@Kislovskiy Kislovskiy marked this pull request as ready for review August 18, 2023 12:00
@Kislovskiy Kislovskiy changed the title TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py Aug 18, 2023
Copy link
Copy Markdown
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given a green CI.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI is green, then LGTM as well!

@ogrisel ogrisel enabled auto-merge (squash) August 18, 2023 14:54
@ogrisel ogrisel merged commit 84273d8 into scikit-learn:main Aug 18, 2023
@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Aug 19, 2023

Merged. Thanks @Kislovskiy for the fix!

@Kislovskiy Kislovskiy deleted the towards-27090-test_bisect_k_means.py branch August 19, 2023 19:19
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants