TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birch.py + test_column_transformer.py#27097
Merged
ogrisel merged 9 commits intoscikit-learn:mainfrom Aug 23, 2023
Conversation
scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py
jjerphan
approved these changes
Aug 18, 2023
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM modulo a small fix and a green CI.
Thank you, @msgomez06. 🙂
sklearn/cluster/tests/test_dbscan.py
Outdated
|
|
||
| def test_dbscan_sparse(): | ||
| core_sparse, labels_sparse = dbscan(sparse.lil_matrix(X), eps=0.8, min_samples=10) | ||
| pytest.mark.parametrize("lil_container", LIL_CONTAINERS) |
Member
There was a problem hiding this comment.
Suggested change
| pytest.mark.parametrize("lil_container", LIL_CONTAINERS) | |
| @pytest.mark.parametrize("lil_container", LIL_CONTAINERS) |
ogrisel
reviewed
Aug 18, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
Beyond Julien's suggestion we can also avoid introducing redundant parameter combinations as follows:
scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.pyscipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + 'test_birch'
This comment was marked as resolved.
This comment was marked as resolved.
scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + 'test_birch'scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birch
scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birchscipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birch + test_column_transformer
scipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birch + test_column_transformerscipy.sparse.*array in sklearn/cluster/tests/test_dbscan.py + test_birch.py + test_column_transformer.py
ogrisel
approved these changes
Aug 23, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well. However to make it easier to review and merge incrementally, please open one PR per submodule next time (unless they are actually dependent on a common change/fix in the code base).
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
…test_dbscan.py` + `test_birch.py` + `test_column_transformer.py` (scikit-learn#27097)
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…test_dbscan.py` + `test_birch.py` + `test_column_transformer.py` (scikit-learn#27097)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…test_dbscan.py` + `test_birch.py` + `test_column_transformer.py` (scikit-learn#27097)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards 27090.
What does this implement/fix? Explain your changes.
This PR introduces sparse containers' list conditionally to the version of SciPy so that we can extend tests as part of 27090.
Any other comments?