Skip to content

CLN Update var name in TargetEncoder to make consistent#27033

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
lucyleeow:te
Aug 8, 2023
Merged

CLN Update var name in TargetEncoder to make consistent#27033
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
lucyleeow:te

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

Reference Issues/PRs

Make var name for X mask consistent in this file.
Related: #26674 (comment)

What does this implement/fix? Explain your changes.

Any other comments?

cc @thomasjpfan

@lucyleeow lucyleeow changed the title TST Update var name to make consistent Update var name in TargetEncoder to make consistent Aug 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4bd770d. Link to the linter CI: here

@thomasjpfan thomasjpfan changed the title Update var name in TargetEncoder to make consistent MNT Update var name in TargetEncoder to make consistent Aug 8, 2023
@thomasjpfan thomasjpfan changed the title MNT Update var name in TargetEncoder to make consistent CLN Update var name in TargetEncoder to make consistent Aug 8, 2023
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 5ecfa8d into scikit-learn:main Aug 8, 2023
@lucyleeow lucyleeow deleted the te branch August 8, 2023 23:11
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants