Skip to content

MNT Exported WeightingStrategy for *_classmode reductions#27030

Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom
Micky774:export_enum
Aug 8, 2023
Merged

MNT Exported WeightingStrategy for *_classmode reductions#27030
OmarManzoor merged 2 commits intoscikit-learn:mainfrom
Micky774:export_enum

Conversation

@Micky774
Copy link
Copy Markdown
Contributor

@Micky774 Micky774 commented Aug 7, 2023

Reference Issues/PRs

As mentioned here in #26828

What does this implement/fix? Explain your changes.

Allows for the cimport of WeightingStrategy primarily for use in #26828

Any other comments?

@Micky774 Micky774 changed the title Exported WeightingStrategy for *_classmode reductions MNT Exported WeightingStrategy for *_classmode reductions Aug 7, 2023
@Micky774 Micky774 added Quick Review For PRs that are quick to review and removed module:metrics cython labels Aug 7, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5413343. Link to the linter CI: here

Copy link
Copy Markdown
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Micky774

@OmarManzoor OmarManzoor merged commit 392c084 into scikit-learn:main Aug 8, 2023
@Micky774 Micky774 deleted the export_enum branch August 8, 2023 13:22
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cython module:metrics Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants