FIX missing_indices were calculated twice in OrdinalEncoder#27017
Merged
OmarManzoor merged 4 commits intoscikit-learn:mainfrom Aug 8, 2023
Merged
FIX missing_indices were calculated twice in OrdinalEncoder#27017OmarManzoor merged 4 commits intoscikit-learn:mainfrom
OmarManzoor merged 4 commits intoscikit-learn:mainfrom
Conversation
thomasjpfan
reviewed
Aug 7, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Please add an entry to the change log at doc/whats_new/v1.4.rst with tag |Efficiency|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
Note that the changelog entry is public facing, so it is best to describe how this PR will impact a user.
thomasjpfan
approved these changes
Aug 7, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
OmarManzoor
approved these changes
Aug 8, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM Thanks @xuefeng-xu
Contributor
Author
|
Sorry, I forgot to add the |
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
…earn#27017) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…earn#27017) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27011