addition of r2_score function (reworked)#27
Closed
AnneLaureF wants to merge 5 commits intoscikit-learn:masterfrom
Closed
addition of r2_score function (reworked)#27AnneLaureF wants to merge 5 commits intoscikit-learn:masterfrom
AnneLaureF wants to merge 5 commits intoscikit-learn:masterfrom
Conversation
added 4 commits
November 29, 2010 15:52
Member
|
is tests pass +1 for the merge |
Member
|
I have a failing doctest: File "/home/varoquau/dev/scikit-learn/scikits/learn/grid_search.py", line 178, in scikits.learn.grid_search.GridSearchCV
Failed example:
clf.fit(X, y).predict([[-0.8, -1]])
Expected:
array([ 1.14])
Got:
array([ 1.13101459])
It seems to me that this means that changing the score used has also changed which method performed best in the grid search. Is this to be expected? It will confuse users (but 0.6 is going to be a frightening release). |
Member
|
there is no reason it should be exactly the same but it should be close. |
Member
|
I'll push this tomorrow if everyone is OK |
Member
|
Yes. Thanks a lot. Could you make sure that the doc test is fixed too. |
Member
|
It's in. All tests passed cleanly, nothing modified. Thanks AnneLaure for the patches. |
glouppe
pushed a commit
to glouppe/scikit-learn
that referenced
this pull request
Feb 3, 2013
Fix some of ogrisel comments
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.