FIX (SLEP6) make Pipeline work with an estimator implementing __len__#26964
Merged
thomasjpfan merged 3 commits intoscikit-learn:mainfrom Aug 2, 2023
Merged
FIX (SLEP6) make Pipeline work with an estimator implementing __len__#26964thomasjpfan merged 3 commits intoscikit-learn:mainfrom
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Aug 1, 2023
glemaitre
reviewed
Aug 1, 2023
glemaitre
approved these changes
Aug 2, 2023
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelinefails if the final estimator implements__len__. This fixes the issue.cc @glemaitre
no changelog is needed since this is not released yet.