Skip to content

DOC Notebook style for ClassifierChain example#26956

Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom
Tialo:docs/notebook-style-chain
Nov 2, 2023
Merged

DOC Notebook style for ClassifierChain example#26956
glemaitre merged 4 commits intoscikit-learn:mainfrom
Tialo:docs/notebook-style-chain

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Jul 31, 2023

This PR suggests updates to ClassifierChain example to make it in notebook style formatting.

Reference Issues/PRs

This was suggested in #26937

What does this implement/fix? Explain your changes.

Any other comments?

If you have any suggestions/remarks feel free to share.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 31, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8a49dcb. Link to the linter CI: here

@Tialo
Copy link
Copy Markdown
Contributor Author

Tialo commented Aug 1, 2023

@adrinjalali fyi

@adrinjalali
Copy link
Copy Markdown
Member

@TomDLT would you have some bandwidth to review this one? (figured you might be a better person to review this than me since you reviewed the original ClassifierChain PR 😁 )

@glemaitre glemaitre assigned glemaitre and unassigned glemaitre Nov 1, 2023
@glemaitre glemaitre self-requested a review November 1, 2023 12:18
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

@glemaitre
Copy link
Copy Markdown
Member

But it looks much nicer. I also spotted that we have a bug if we would like to use a VotingClassifier.

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

@glemaitre glemaitre merged commit beaf4bb into scikit-learn:main Nov 2, 2023
@Tialo Tialo deleted the docs/notebook-style-chain branch November 2, 2023 16:48
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants