Skip to content

DOC update related packages#26922

Merged
adrinjalali merged 18 commits intoscikit-learn:mainfrom
lorentzenchr:related_packages
Jul 30, 2023
Merged

DOC update related packages#26922
adrinjalali merged 18 commits intoscikit-learn:mainfrom
lorentzenchr:related_packages

Conversation

@lorentzenchr
Copy link
Copy Markdown
Member

Reference Issues/PRs

Closes #26906.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 28, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 24a546b. Link to the linter CI: here

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment on lines 211 to 212
- `Keras <https://www.tensorflow.org/api_docs/python/tf/keras>`_ High-level API for
TensorFlow with a scikit-learn inspired API.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be replaced with scikeras: https://github.com/adriangb/scikeras

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scikeras come at line 217.
From what I read in https://www.tensorflow.org/api_docs/python/tf/keras/Model, it seems fine to keep this entry. But no strong feeling.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keras has a scikit-learn inspired API, but it does not really work well with our meta-estimators. I am +1 on removing the Keras entry.

@adrinjalali adrinjalali merged commit fa87f28 into scikit-learn:main Jul 30, 2023
@lorentzenchr lorentzenchr deleted the related_packages branch July 31, 2023 07:55
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC Remove some links from the list of related packages

3 participants