Skip to content

MNT Fixed linting error in plot_select_from_model_diabetes.py#26915

Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
Micky774:lint_fix
Jul 27, 2023
Merged

MNT Fixed linting error in plot_select_from_model_diabetes.py#26915
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
Micky774:lint_fix

Conversation

@Micky774
Copy link
Copy Markdown
Contributor

@Micky774 Micky774 commented Jul 27, 2023 •
edited
Loading

Reference Issues/PRs

Fixes linting error introduced in #26205

What does this implement/fix? Explain your changes.

Applied ruff check --select I --fix examples/feature_selection/plot_select_from_model_diabetes.py

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 27, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2edbbd5. Link to the linter CI: here

@jeremiedbb
Copy link
Copy Markdown
Member

jeremiedbb commented Jul 27, 2023

We did not catch it in that PR because the last CI run was prior to the introduction of ruff with isort rules, right ?
We've already faced this issue several times. Usually when I want to merge a PR for which the last push is quite old, I sync the branch even though it has no conflicts, just to retrigger the CI to be safe.

@jeremiedbb jeremiedbb enabled auto-merge (squash) July 27, 2023 12:49
@Micky774
Copy link
Copy Markdown
Contributor Author

Micky774 commented Jul 27, 2023

Usually when I want to merge a PR for which the last push is quite old, I sync the branch even though it has no conflicts, just to retrigger the CI to be safe.

Yup that's definitely going to be my pattern from now on as well. I think, in this instance, I didn't realize how old the last run was 😅

@adrinjalali
Copy link
Copy Markdown
Member

adrinjalali commented Jul 27, 2023

We should probably have something which blocks merges if they haven't been synced with main for more than like 3 days lol

@Micky774
Copy link
Copy Markdown
Contributor Author

Micky774 commented Jul 27, 2023

Also note this will need a manual merge due to the failing linux_aarch64_test

@jeremiedbb jeremiedbb merged commit 9e09e4d into scikit-learn:main Jul 27, 2023
@Micky774 Micky774 deleted the lint_fix branch July 27, 2023 13:51
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@Micky774 @punndcoder28
MNT Fixed linting error in plot_select_from_model_diabetes.py (scik…
23e3ab5 
…it-learn#26915)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@Micky774 @glemaitre
MNT Fixed linting error in plot_select_from_model_diabetes.py (scik…
7518eef 
…it-learn#26915)
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@Micky774 @jeremiedbb
MNT Fixed linting error in plot_select_from_model_diabetes.py (#26915)
0c90414
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Micky774 @REDVM
MNT Fixed linting error in plot_select_from_model_diabetes.py (scik…
153b2e8 
…it-learn#26915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

Documentation No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Micky774 @jeremiedbb @adrinjalali