Fix good Conda versions for updating lockfile#26908
Merged
lesteve merged 2 commits intoscikit-learn:mainfrom Aug 7, 2023
Merged
Fix good Conda versions for updating lockfile#26908lesteve merged 2 commits intoscikit-learn:mainfrom
lesteve merged 2 commits intoscikit-learn:mainfrom
Conversation
The fix for a Conda bug was not released until v23.7.0. Ref: <conda/conda-lock#408 (comment)> Ref: <https://github.com/conda/conda/releases/tag/23.7.0>
lesteve
approved these changes
Aug 7, 2023
Merged
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the version numbers of Conda from the lockfile script which are compatible with conda-lock.
This is under the assumption that the fix is effective, which I haven't personally tested.
Ref: conda/conda-lock#408 (comment)
Ref: https://github.com/conda/conda/releases/tag/23.7.0
CC @lesteve