ENH add metadata routing to cross_val*#26896
Merged
glemaitre merged 29 commits intoscikit-learn:mainfrom Aug 9, 2023
Merged
Conversation
28 tasks
Member
Author
|
@glemaitre @OmarManzoor @thomasjpfan this is ready for review. |
glemaitre
reviewed
Aug 3, 2023
glemaitre
reviewed
Aug 3, 2023
glemaitre
reviewed
Aug 3, 2023
glemaitre
reviewed
Aug 3, 2023
glemaitre
reviewed
Aug 3, 2023
glemaitre
reviewed
Aug 3, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Just a couple of nitpicks. Otherwise, I am fine with the design.
In the future we could improve:
- the code sharing between
cross-valdiateandcross_val_predict - how
_MultiMetricScoreris passed around. It would make sense to create such instance when checking and passing it around and to create ato_dictto convert a scorer back to what is needed later on.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
… into slep6/cross_val
This was referenced Aug 3, 2023
Member
Author
OmarManzoor
reviewed
Aug 7, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Generally looks good. Added a few comments.
OmarManzoor
reviewed
Aug 8, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
A few more comments.
OmarManzoor
approved these changes
Aug 8, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @adrinjalali
Member
|
LGTM. Thanks @adrinjalali |
This was referenced Aug 9, 2023
Member
|
I guess we can promote this to a major feature already. |
Member
Author
|
Soon I'll update the changelog to create a separate section for SLEP006 @lorentzenchr |
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds metadata routing to
cross_val*functions.Note that this PR does NOT route metadata for
predictmethod of the estimator if any.Closes #13432
Fixes #4632
Fixes #7646
Fixes #20349