MNT SLEP6 move common metadata routing test objects#26894
Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom Jul 25, 2023
Merged
MNT SLEP6 move common metadata routing test objects#26894glemaitre merged 3 commits intoscikit-learn:mainfrom
glemaitre merged 3 commits intoscikit-learn:mainfrom
Conversation
Member
|
I know it is not from this PR changes, but we could fix the missing coverage line here: https://github.com/scikit-learn/scikit-learn/pull/26894/files#annotation_12870579022 |
OmarManzoor
approved these changes
Jul 25, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM, Thanks @adrinjalali
Member
Author
|
Added a test for the registry @glemaitre |
Member
|
Thanks @adrinjalali. LGTM. |
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves common classes and functions for metadata routing to a separate file under tests. This PR does NOT introduce any new classes, it only removes some duplicates, renames some to make them coherent, and fixes the tests to use the new classes.
cc @thomasjpfan since had asked for such cleanups.
cc @OmarManzoor @glemaitre