MNT Improve robustness of sparse test in HDBSCAN#26889
Merged
OmarManzoor merged 6 commits intoscikit-learn:mainfrom Jul 27, 2023
Merged
MNT Improve robustness of sparse test in HDBSCAN#26889OmarManzoor merged 6 commits intoscikit-learn:mainfrom
HDBSCAN#26889OmarManzoor merged 6 commits intoscikit-learn:mainfrom
Conversation
thomasjpfan
reviewed
Jul 25, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…kit-learn into hdbscan_sparse_test Includes simplification of test
OmarManzoor
approved these changes
Jul 27, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Micky774
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26801
What does this implement/fix? Explain your changes.
In pursuit of another feature enhancement, I noticed that the tests were missing certain cases and could be made more robust
Any other comments?