DOC Highlight differerence between SVC/R and LinearSVC/R#26825
Merged
OmarManzoor merged 6 commits intoscikit-learn:mainfrom Aug 10, 2023
Merged
DOC Highlight differerence between SVC/R and LinearSVC/R#26825OmarManzoor merged 6 commits intoscikit-learn:mainfrom
OmarManzoor merged 6 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
reviewed
Jul 13, 2023
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Thanks, LGTM other than some small points.
adrinjalali
approved these changes
Jul 31, 2023
Member
Author
glemaitre
approved these changes
Aug 1, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Just nitpicks regarding double backticks.
Member
|
FWIW, I think double backticks should stay double backtics. I'm happy not to force a double backtick, but I don't think we should convert existing double backtics to single ones 😁 |
OmarManzoor
approved these changes
Aug 10, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @StefanieSenger
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #26812
What does this implement/fix? Explain your changes.
This PR suggests a way to prevent confusion about similarities and differences between SVC / SCR and LinearSCV / LinearSCR, especially regarding the regularization of an intercept (that is implemented differently in the underlying libraries).