DOC: added dropdowns to module 1.9 naive bayes#26819
Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom Nov 2, 2023
Merged
DOC: added dropdowns to module 1.9 naive bayes#26819glemaitre merged 3 commits intoscikit-learn:mainfrom
glemaitre merged 3 commits intoscikit-learn:mainfrom
Conversation
54 tasks
ArturoAmorQ
approved these changes
Jul 24, 2023
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Apart from this small comment, LGTM :)
doc/modules/naive_bayes.rst
Outdated
| by a considerable margin) on text classification tasks. | ||
|
|
||
| |details-start| | ||
| **Weights forecalculation** |
Member
There was a problem hiding this comment.
I think this word is a bit unknown to non-native speakers. I would rather simply say "calculation".
Suggested change
| **Weights forecalculation** | |
| **Weights calculation** |
Contributor
Author
There was a problem hiding this comment.
yeah totally agree, thanks!
let me change that
ac70f67 to
be3fbde
Compare
be3fbde to
42160b8
Compare
ArturoAmorQ
approved these changes
Jul 25, 2023
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Thanks again for the change. This PR LGTM in it's current state.
Just notice it is not a good practice to force push, as it makes more difficult the reviewing process.
glemaitre
approved these changes
Nov 2, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
I quickly added dropdown menu for the references as well.
LGTM.
Thanks @MikiPWata
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
add dropdowns to the module 1.9 Naive Bayes from Issue #26617
What does this implement/fix? Explain your changes.
Folded:
Any other comments?