MNT clean up old scipy sparse.linalg.cg fallback code#26813
Merged
thomasjpfan merged 2 commits intoscikit-learn:mainfrom Jul 10, 2023
Merged
MNT clean up old scipy sparse.linalg.cg fallback code#26813thomasjpfan merged 2 commits intoscikit-learn:mainfrom
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
Conversation
adrinjalali
approved these changes
Jul 10, 2023
thomasjpfan
approved these changes
Jul 10, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atol parameter exists since scipy 1.1 https://docs.scipy.org/doc/scipy-1.1.0/reference/generated/scipy.sparse.linalg.cg.html and our min supported version is scipy 1.5.