Skip to content

DOC Add dropdowns to module 7.1 Toy datasets#26710

Merged
ArturoAmorQ merged 4 commits intoscikit-learn:mainfrom
rprkh:doc_dropdowns_toy_datasets
Aug 28, 2023
Merged

DOC Add dropdowns to module 7.1 Toy datasets#26710
ArturoAmorQ merged 4 commits intoscikit-learn:mainfrom
rprkh:doc_dropdowns_toy_datasets

Conversation

@rprkh
Copy link
Copy Markdown
Contributor

@rprkh rprkh commented Jun 27, 2023

Reference Issues/PRs

Towards #26617

What does this implement/fix? Explain your changes.

Includes dropdowns for the references of the toy datasets.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 27, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: bdfd840. Link to the linter CI: here

Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rprkh. It overall LGTM, just notice that the indentation in the list of references was necessary for the .. topic:: directive to work and that is no longer the case.

Can you please remove the indentation and reformat the paragraphs length accordingly?

@rprkh
Copy link
Copy Markdown
Contributor Author

rprkh commented Jul 26, 2023

Added the changes

Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rprkh! LGTM in its current state :)

@ArturoAmorQ
Copy link
Copy Markdown
Member

Thanks again :) Merging this one!

@ArturoAmorQ ArturoAmorQ merged commit 5c57694 into scikit-learn:main Aug 28, 2023
@rprkh rprkh deleted the doc_dropdowns_toy_datasets branch August 29, 2023 07:05
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants