DOC Add dropdowns to module 1.1 Linear Models#26623
Merged
ArturoAmorQ merged 16 commits intoscikit-learn:mainfrom Oct 11, 2023
Merged
DOC Add dropdowns to module 1.1 Linear Models#26623ArturoAmorQ merged 16 commits intoscikit-learn:mainfrom
ArturoAmorQ merged 16 commits intoscikit-learn:mainfrom
Conversation
54 tasks
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
I think that this is super useful!!
One tiny comment: I think that we should also fold 1.1.8.1
And +1 for merge once this is implemented
glemaitre
reviewed
Jun 22, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Here are some comments. I think that we can further improve the page but I would prefer to make smaller PR dedicated to each section to make it easy to review.
ArturoAmorQ
approved these changes
Jul 12, 2023
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Can you please solve the conflicts with main, @Tech-Netiums ? Otherwise LGTM :)
ArturoAmorQ
reviewed
Oct 11, 2023
ArturoAmorQ
reviewed
Oct 11, 2023
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
I will take the liberty of pushing some commits to your PR to avoid breaking sphinx permalinks.
ArturoAmorQ
reviewed
Oct 11, 2023
ArturoAmorQ
reviewed
Oct 11, 2023
Member
|
Thanks for your time and effort @Tech-Netiums, merging :) |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dropdowns to submodule 1.1 Linear models regarding #26617