FIX Correct the initiatialization of precisions_cholesky_ from precisions_init#26416
Merged
OmarManzoor merged 54 commits intoscikit-learn:mainfrom Jul 20, 2023
mchikyt3:fix-precisions-init
Merged
FIX Correct the initiatialization of precisions_cholesky_ from precisions_init#26416OmarManzoor merged 54 commits intoscikit-learn:mainfrom mchikyt3:fix-precisions-init
precisions_cholesky_ from precisions_init#26416OmarManzoor merged 54 commits intoscikit-learn:mainfrom
mchikyt3:fix-precisions-init
Conversation
jjerphan
reviewed
Jun 1, 2023
Member
jjerphan
left a comment
There was a problem hiding this comment.
Thank you for reporting the issue and proposing a fix.
Your observation and your correction proposal are valid. Here are just a few comments to avoid performance regressions.
precisions_cholesky_ from precisions_initprecisions_cholesky_ from precisions_init
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
…terized `COVARIANCE_TYPE`.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
reviewed
Jun 2, 2023
Contributor
Author
|
The change log has been moved to |
Member
|
@dengemann do you want to have a look at this PR? |
OmarManzoor
reviewed
Jul 19, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @mchikyt3. This looks good overall. I just pointed out some changes related to the docs and naming.
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Contributor
Author
The changes have been committed. Thanks for your comments. Please approve if there's no further questions. @OmarManzoor |
OmarManzoor
reviewed
Jul 20, 2023
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
OmarManzoor
approved these changes
Jul 20, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM! Thanks @mchikyt3
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26415
What does this implement/fix? Explain your changes.
This PR fixes the bug of initializing
precisions_cholesky_fromprecisions_initin the_initializemethod.Any other comments?