✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 7f01cd7. Link to the linter CI: here}

Pinging some recent contributors to LogisticRegression: @jeremiedbb, @lorentzenchr, @glemaitre. Could you have a quick look?

It would help to point to a formula (eg in the user guide) for the regularized one such that it is crystal clear.

Thanks, @lorentzenchr. I found a regularized formulation at https://scikit-learn.org/stable/modules/linear_model.html#binary-case. How would I link this and refer to an equation?

@glemaitre @lucyleeow Could you help out how to link to a formula in the user guide?

Maybe :math:numref: would work? (Would need to add a :label: to the math equation in linear_model.rst)

Otherwise, potentially :name: may work for a math block too, e.g. amending the equation to format,

.. math::
    :name: <eq name>

:math:numref: should be the way to go though!

Hmm it does look a bit odd now that this specific equation is the only one on the page that has a number next to it. Maybe :name: would be better?

.. math::
    :name: <name>

I need to refer to this :ref:`eq title <name>`

With all three approaches

.. math:: \min_{w} C \sum_{i=1}^n \left(-y_i \log(\hat{p}(X_i)) - (1 - y_i) \log(1 - \hat{p}(X_i))\right) + r(w).
   :label: logreg-regularized

.. math::
   :label: logreg-regularized
   
    \min_{w} C \sum_{i=1}^n \left(-y_i \log(\hat{p}(X_i)) - (1 - y_i) \log(1 - \hat{p}(X_i))\right) + r(w).

and

.. math::
    :name: regularized-logisticloss
   
    \min_{w} C \sum_{i=1}^n \left(-y_i \log(\hat{p}(X_i)) - (1 - y_i) \log(1 - \hat{p}(X_i))\right) + r(w).

the equation receives a number (1) in the top-left.

Thanks for testing it all! I would just go with :label: and accept the number.

We could think about working on adding labels to all equations in our docs WDYT @lorentzenchr ?

@lucyleeow First of all, thanks for helping out.

I would not add labels to all equations we have, but make more use of labels on a case by case where needed base.

No worries, probably unnecessary. Just thought the numbering looked odd, especially as it isn't the first equation in the page. No matter.

I've added the same text to LogisticRegressionCV.

@lucyleeow @lorentzenchr Is there anything still needed to do before we can merge this?