Skip to content

DOC Add missing cross validation image alt#26261

Merged
adrinjalali merged 1 commit intoscikit-learn:mainfrom
marekhanus:feature/cross_validation_alt
Jul 28, 2023
Merged

DOC Add missing cross validation image alt#26261
adrinjalali merged 1 commit intoscikit-learn:mainfrom
marekhanus:feature/cross_validation_alt

Conversation

@marekhanus
Copy link
Copy Markdown
Contributor

@marekhanus marekhanus commented Apr 22, 2023

Reference Issues/PRs

See also #21214.

What does this implement/fix? Explain your changes.

Any other comments?

@betatim
Copy link
Copy Markdown
Member

betatim commented Apr 24, 2023

Thanks for taking the time to work on this. While looking at the alt text you added and reading the issue you linked I started thinking about "what makes a good alt text?". I found this comment and the one after it useful. As well as the content they link to.

Instead of repeating the name of the figure as the alt text I think having a short description a la http://diagramcenter.org/specific-guidelines-g.html#71 would be a good alt text. Describing the important parts that can be seen in the image. In this context I think "important" is about "what do I need to take away from this image to better understand the text?". What do you think @marekhanus ?

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a better alt.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 28, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2a0cbe8. Link to the linter CI: here

@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 52e9f6e to 2d84eb0 Compare July 28, 2023 07:13
@marekhanus
Copy link
Copy Markdown
Contributor Author

Sorry @betatim, I forgot to change it.

--

I think this should be a better alt.

Thanks @adrinjalali.

@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 2d84eb0 to 754852e Compare July 28, 2023 07:28
Thanks @adrinjalali.

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 754852e to 2a0cbe8 Compare July 28, 2023 07:31
@adrinjalali adrinjalali merged commit 1090121 into scikit-learn:main Jul 28, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants