Skip to content

Conversation

@ScottMGustafson
Copy link
Contributor

Reference Issues/PRs

Fixes #25422

What does this implement/fix? Explain your changes.

Adds a tiny detail to the ColumnTransformer docstring about behavior with dataframes when remainder="passthrough".

Any other comments?

@betatim betatim added Documentation Quick Review For PRs that are quick to review labels Jan 18, 2023
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for adding this missing detail in the docs.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan changed the title Add detail about dataframe passthrough columns DOC Add detail about dataframe passthrough columns Jan 18, 2023
@thomasjpfan thomasjpfan merged commit 0260283 into scikit-learn:main Jan 18, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation module:compose Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ColumnTransformer not honoring passthrough on transform with pandas when passthroughs not present in fit data

4 participants