FIX Support read-only sparse datasets for Tree-based estimators
#25341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const-qualify BaseSparseSplitter attributes of CSR data const-qualify BaseSparseSplitter attributes of CSR or CSC data
const-qualify BaseSparseSplitter attributes of CSR or CSC data Tree-based estimators
thomasjpfan
reviewed
Jan 11, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! There is a merge conflict with main to be resolved.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
commented
Jan 12, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ikit-learn#25341) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ikit-learn#25341) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
…ikit-learn#25341) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
…5341) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25333.
Fixes #25247.
What does this implement/fix? Explain your changes.
In some workflows using
DecisionTree*(this includeRandomForest*andExtraTrees*):joblibmight memmap arrays making their buffer read-only.Those cases are correctly supported when using dense datasets thanks to
const-qualification of memoryview in Cython. Yet those cases aren't currently supported when using sparse datasets (for instance whenXis provided as a CSC or as a CSR matrix).const-qualifying CSC or CSR buffers (i.e.data,indicesandindptr) inBaseSparseSplitterallows supporting those cases when using sparse datasets.