DOC improve inline comments in SAGA #25100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can i work on this issue |
jjerphan
reviewed
Dec 5, 2022
Member
|
@sanjail3: the issue is unfortunately already addressed by this PR. |
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
ogrisel
approved these changes
Dec 13, 2022
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well. I will commit the following 2 nits and merge.
Member
|
Thanks for the improvement @TomDLT. Let me try the auto merge feature on this PR :) |
Vincent-Maladiere
pushed a commit
to Vincent-Maladiere/scikit-learn
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inline comments to better describe the just-in-time (JIT) update system and the prox operator update in SAGA.
Fixes #24679