DOC Ensures that svd_flip passes numpydoc validation#24581
Merged
thomasjpfan merged 4 commits intoscikit-learn:mainfrom Oct 11, 2022
Merged
DOC Ensures that svd_flip passes numpydoc validation#24581thomasjpfan merged 4 commits intoscikit-learn:mainfrom
thomasjpfan merged 4 commits intoscikit-learn:mainfrom
Conversation
Ensures sklearn.utils.extmath.svd_flip passes npdoc
Removed svd_flip from function doctring ignore list
thomasjpfan
reviewed
Oct 5, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @mansi1597 !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Oct 11, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the update! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Adds valid function parameters description and adds valid return statement description.
Removed extra break lines.