Skip to content

DOC Ensures that sklearn.utils.extmath.weighted_mode passes numpydoc validation#24571

Merged
jeremiedbb merged 5 commits intoscikit-learn:mainfrom
awinml:weighted_mode-numpydoc_validation
Oct 7, 2022
Merged

DOC Ensures that sklearn.utils.extmath.weighted_mode passes numpydoc validation#24571
jeremiedbb merged 5 commits intoscikit-learn:mainfrom
awinml:weighted_mode-numpydoc_validation

Conversation

@awinml
Copy link
Copy Markdown
Contributor

@awinml awinml commented Oct 4, 2022

Reference Issues/PRs

Addresses #21350
Ensures that sklearn.utils.extmath.weighted_mode passes numpydoc_validation.

What does this implement/fix? Explain your changes.

  • Updated description to start with infinitive verb.
  • Updated descriptions of parameters to represent shape of input.
  • Reordered sections so that See Also is before Examples.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awinml

@jeremiedbb jeremiedbb merged commit c674e58 into scikit-learn:main Oct 7, 2022
@awinml
Copy link
Copy Markdown
Contributor Author

awinml commented Oct 8, 2022

Thanks @jeremiedbb!

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Oct 9, 2022
…validation (scikit-learn#24571)

Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
…validation (scikit-learn#24571)

Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants