Skip to content

DOC Ensures that sklearn.utils.extmath.safe_sparse_dot passes numpydoc validation#24567

Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
awinml:safe_sparse_dot-numpydoc_validation
Oct 7, 2022
Merged

DOC Ensures that sklearn.utils.extmath.safe_sparse_dot passes numpydoc validation#24567
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
awinml:safe_sparse_dot-numpydoc_validation

Conversation

@awinml
Copy link
Copy Markdown
Contributor

@awinml awinml commented Oct 3, 2022

Reference Issues/PRs

Addresses #21350
Ensures that sklearn.utils.extmath.safe_sparse_dot passes numpydoc validation.

What does this implement/fix? Explain your changes.

  • The sklearn.utils.extmath.safe_sparse_dot docstring passed all tests without any changes.

  • Removed sklearn.utils.extmath.safe_sparse_dot from the FUNCTION_DOCSTRING_IGNORE_LIST at scikit-learn/sklearn/tests/test_docstrings.py.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awinml

@jeremiedbb jeremiedbb merged commit 77762b6 into scikit-learn:main Oct 7, 2022
@awinml
Copy link
Copy Markdown
Contributor Author

awinml commented Oct 8, 2022

Thanks @jeremiedbb!

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Oct 9, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants