DOC Ensure that sklearn.utils.is_scalar_nan passes numpydoc validation#24562
Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom Oct 3, 2022
Merged
DOC Ensure that sklearn.utils.is_scalar_nan passes numpydoc validation#24562glemaitre merged 3 commits intoscikit-learn:mainfrom
glemaitre merged 3 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Oct 3, 2022
glemaitre
reviewed
Oct 3, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
Our convention is to use the Python type. While it is passing the numpydoc, we can make the change in the same PR.
Member
|
I merge the changes since this is a really small change. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Oct 9, 2022
scikit-learn#24562) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
scikit-learn#24562) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Adds parameter and return value descriptions