DOC ensures sklearn.utils.shuffle passes numpydoc validation#24367
Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom Sep 7, 2022
zadilkhwaja:shuffleNew
Merged
DOC ensures sklearn.utils.shuffle passes numpydoc validation#24367glemaitre merged 4 commits intoscikit-learn:mainfrom zadilkhwaja:shuffleNew
glemaitre merged 4 commits intoscikit-learn:mainfrom
zadilkhwaja:shuffleNew
Conversation
Member
|
You should as well run black on the file since the linter complains. |
Member
|
black complains about the invisible trailing spaces. To fix this: The black version number comes from https://scikit-learn.org/dev/developers/contributing.html#how-to-contribute |
Contributor
Author
|
@ogrisel Hi, can you guide me on how to resolve these new errors |
glemaitre
reviewed
Sep 7, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
We need to add a description to be compliant with the numpydoc validation. I made a suggestion that you can accept and it should solve the CIs issue.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Member
|
Thanks @zadilkhwaja |
Contributor
Author
Thankyou for the help. I was able to understand a lot of new things. |
Member
|
Nice @zadilkhwaja Hope that you can continue contributing. I will be happy to review your subsequent PR ;) |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…learn#24367) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #21350 .
What does this implement/fix? Explain your changes.
DOC ensures sklearn.utils.shuffle passes numpydoc validation