Skip to content

DOC Ensures that sklearn.utils.extmath.stable_cumsum passes numpydoc validation#24348

Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom
TheDevPanda:numpydoc_stable_cumsum
Sep 4, 2022
Merged

DOC Ensures that sklearn.utils.extmath.stable_cumsum passes numpydoc validation#24348
glemaitre merged 1 commit intoscikit-learn:mainfrom
TheDevPanda:numpydoc_stable_cumsum

Conversation

@TheDevPanda
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Ensures that sklearn.utils.extmath.stable_cumsum's docstring passes numpydoc validation as part of #21350.

What does this implement/fix? Explain your changes.

  • Add return description to docstring.
  • Clarify what happens if the stable cumsum check fails (warning).

Any other comments?

#euroscipy2022

@glemaitre glemaitre changed the title [MRG] DOC Ensures that sklearn.utils.extmath.stable_cumsum passes numpydoc validation DOC Ensures that sklearn.utils.extmath.stable_cumsum passes numpydoc validation Sep 4, 2022
@glemaitre glemaitre merged commit 4575637 into scikit-learn:main Sep 4, 2022
@glemaitre
Copy link
Copy Markdown
Member

Thanks @TheDevPanda LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants