DOC Ensures that mean_pinball_loss passes numpydoc validation#24336
Merged
jeremiedbb merged 1 commit intoscikit-learn:mainfrom Sep 2, 2022
Merged
DOC Ensures that mean_pinball_loss passes numpydoc validation#24336jeremiedbb merged 1 commit intoscikit-learn:mainfrom
jeremiedbb merged 1 commit intoscikit-learn:mainfrom
Conversation
jeremiedbb
approved these changes
Sep 2, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks @ichko. LGTM assuming CI is green
ogrisel
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
Fixes docstring for
mean_pinball_loss.What does this implement/fix? Explain your changes.
Add whitespace and capitalize the docstring of one of the parameters -
alpha.Any other comments?
#euroscipy2022