DOC Ensure externals._packaging.version.parse passes numpydoc validation#24320
Merged
glemaitre merged 6 commits intoscikit-learn:mainfrom Sep 4, 2022
Merged
DOC Ensure externals._packaging.version.parse passes numpydoc validation#24320glemaitre merged 6 commits intoscikit-learn:mainfrom
glemaitre merged 6 commits intoscikit-learn:mainfrom
Conversation
ogrisel
reviewed
Sep 2, 2022
ogrisel
reviewed
Sep 2, 2022
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the PR. I am not sure what line length numpydoc prefers in the docstring but I believe we typically break lines at the 79 columns mark in docstrings.
Contributor
Author
|
thanks @ogrisel for your comments. Should be good now |
ogrisel
approved these changes
Sep 2, 2022
Member
|
@maikia it seems that the circle CI failure comes from a circle ci configuration on your fork https://app.circleci.com/pipelines/github/maikia/scikit-learn/ instead of: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/ Maybe you should disable this pipeline in your circle ci configuration if you don't need it anymore. |
glemaitre
reviewed
Sep 3, 2022
Member
|
LGTM. Just awaiting for the CI to turn green. |
Member
|
Thanks @maikia |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…ion (scikit-learn#24320) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #21350
@adrinjalali @glemaitre
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?