Skip to content

DOC Ensure _dict_learning.dict_learning passes numpydoc validation#24316

Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom
maikia:dict_learning_docstring
Sep 3, 2022
Merged

DOC Ensure _dict_learning.dict_learning passes numpydoc validation#24316
glemaitre merged 2 commits intoscikit-learn:mainfrom
maikia:dict_learning_docstring

Conversation

@maikia
Copy link
Copy Markdown
Contributor

@maikia maikia commented Sep 2, 2022

towards #21350

@adrinjalali

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

MiniBatchSparsePCA
dict_learning_online : Solve a dictionary learning matrix factorization problem online.
DictionaryLearning : Find a dictionary that sparsely encodes data.
MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary learning algorithm.
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary learning algorithm.
MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary
learning algorithm.

Thanks for the PR @maikia! My guess is that the CI is failing due to the maximum line length convention.

@maikia
Copy link
Copy Markdown
Contributor Author

maikia commented Sep 2, 2022

thanks @ArturoAmorQ
should be good now

@glemaitre glemaitre merged commit 3a9e51b into scikit-learn:main Sep 3, 2022
@glemaitre
Copy link
Copy Markdown
Member

Thanks @maikia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants