Skip to content

DOC Ensures that load_svmlight_files passes numpydoc validation#24164

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
fcharras:21350_fix_load_svmlight_files
Aug 10, 2022
Merged

DOC Ensures that load_svmlight_files passes numpydoc validation#24164
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
fcharras:21350_fix_load_svmlight_files

Conversation

@fcharras
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses #21350

Comment on lines +271 to +272
https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/multilabel.html
).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our character limit is 88, so that ) should fit. Did you get an error here from the tests or a linter?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reviews! No, I cut the line out of habit for 80 (oops). Let me fix that.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.datasets._svmlight_format_io.load_svmlight_files passes numpydoc validation DOC Ensures that load_svmlight_files passes numpydoc validation Aug 10, 2022
@thomasjpfan thomasjpfan merged commit 82f4892 into scikit-learn:main Aug 10, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants