Skip to content

DOC Ensures that load_svmlight_file passes numpydoc validation#24163

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
fcharras:21350_fix_load_svmlight_file
Aug 12, 2022
Merged

DOC Ensures that load_svmlight_file passes numpydoc validation#24163
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
fcharras:21350_fix_load_svmlight_file

Conversation

@fcharras
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses #21350

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Comment on lines +141 to +142
The target. The output type depends on the value of the parameter
``multilabel``.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be explicit and state that a list of tuples is returned when multilabel=True?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, WDYT ?

@fcharras fcharras force-pushed the 21350_fix_load_svmlight_file branch from bc45fc9 to 12499c1 Compare August 12, 2022 15:16
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.datasets._svmlight_format_io.load_svmlight_file passes numpydoc validation DOC Ensures that load_svmlight_file passes numpydoc validation Aug 12, 2022
@thomasjpfan thomasjpfan merged commit b0e1bb9 into scikit-learn:main Aug 12, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants