Skip to content

DOC Ensures that sklearn.datasets._samples_generator.make_spd_matrix passes numpydoc validation#23974

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
stellalin7:Issue_21350-sklearn.datasets._samples_generator.make_spd_matrix
Jul 21, 2022
Merged

DOC Ensures that sklearn.datasets._samples_generator.make_spd_matrix passes numpydoc validation#23974
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
stellalin7:Issue_21350-sklearn.datasets._samples_generator.make_spd_matrix

Conversation

@stellalin7
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Addresses 21350

What does this implement/fix? Explain your changes.

  1. Remove sklearn.datasets._samples_generator.make_spd_matrix from test_doctrings.py FUNCTION_DOCSTRING_IGNORE_LIST.
  2. Fix SA04: Missing description for See Also "make_sparse_spd_matrix" reference

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM

@thomasjpfan thomasjpfan merged commit 2e49193 into scikit-learn:main Jul 21, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Stella Lin <stella.lin@aexp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants