DOC Ensure sigmoid_kernel passes numpydoc validation#23955
Merged
jeremiedbb merged 9 commits intoscikit-learn:mainfrom Jul 21, 2022
Merged
Conversation
- Add period at the end of summary. - Add description for parameter "X". - Add description for parameter "coef0". - Add description for return value.
jeremiedbb
reviewed
Jul 19, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @Mathews-Tom
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Micky774
reviewed
Jul 20, 2022
Contributor
Micky774
left a comment
There was a problem hiding this comment.
Hey there @Mathews-Tom, thanks for the PR! Left feedback on some minor wording. My comments for gamma and coef0 are the same as in your other PR #23953, so if we reach a concensus in one PR it should be applied in all relevant PRs (e.g. accept/reject this expanded description).
Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…23955) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Address #21350
What does this implement/fix? Explain your changes.
sklearn.metrics.pairwise.sigmoid_kernelfrom test_doctrings.pyFUNCTION_DOCSTRING_IGNORE_LIST.