DOC Ensure pairwise_distances_argmin_min passes numpydoc validation#23952
Merged
thomasjpfan merged 5 commits intoscikit-learn:mainfrom Jul 19, 2022
Conversation
- Change return value description to start with capital letter. - Add description for See Also "pairwise_distances" reference. - Add description for See Also "pairwise_distances_argmin" reference.
jeremiedbb
reviewed
Jul 19, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @Mathews-Tom. Here are a few suggestions
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
thomasjpfan
approved these changes
Jul 19, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…scikit-learn#23952) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
…#23952) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Address #21350
What does this implement/fix? Explain your changes.
sklearn.metrics.pairwise.pairwise_distances_argmin_minfrom test_doctrings.pyFUNCTION_DOCSTRING_IGNORE_LIST.