DOC Ensure additive_chi2_kernel passes numpydoc validation#23943
Merged
jeremiedbb merged 10 commits intoscikit-learn:mainfrom Jul 19, 2022
Merged
DOC Ensure additive_chi2_kernel passes numpydoc validation#23943jeremiedbb merged 10 commits intoscikit-learn:mainfrom
additive_chi2_kernel passes numpydoc validation#23943jeremiedbb merged 10 commits intoscikit-learn:mainfrom
Conversation
- Remove double line break between sections. - Reorder sections. - Restructure summary to fit in a single line. - Add description to Parameter "X". - Add description to Return value.
- Remove double line break between sections.
jeremiedbb
reviewed
Jul 19, 2022
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @Mathews-Tom. I made some suggestions to keep local consistency with other kernels defined in this file
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…learn#23943) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Address #21350
What does this implement/fix? Explain your changes.
sklearn.metrics.pairwise.additive_chi2_kernelfrom test_doctrings.pyFUNCTION_DOCSTRING_IGNORE_LIST.